Mechanics Throat Spray and Magician

[desertdoggo]

What type of bug are you reporting? Mechanics

What is the bug?
Magician does not always steal the item
Testing throat spray delphox with psychic noise and sometimes it steals the turn throat spray is activated and sometimes it does not.

Are you able to replicate it? If so, how?
https://replay.pokemonshowdown.com/gen9anythinggoes-2055483507?p2
delphox steals the black sludge on the same turn

https://replay.pokemonshowdown.com/gen9anythinggoes-2055474619?p2
delphox does not steal the black sludge turn one and then in turn two delphox and grafaiai use switcheroo to prove grafaiai is holding an item.
adding a different pokemon and/or item seems to effect it in some way? However:

https://replay.pokemonshowdown.com/gen9ubers-2052239136 (this is where it was originally noticed)
turn 21 the same interaction occurs and delphox does not steal the item while there are other mons and items still left in the battle. the sets were gone over throughly, the grafaiai is holding a black sludge, psychic noise's ability takes effect here and does not grant it the passive recover at the end of the turn (tired of explaining this to the help room)

more examples:
https://replay.pokemonshowdown.com/gen9anythinggoes-2054750204-bexe5eht3mtao37gbjt4tom50g3dtewpw
works here

https://replay.pokemonshowdown.com/gen9ou-2054745125-tze038bjqrqnpd3a533c1k80kkyllcupw
doesn't work here. again, psychic noise prevents the black sludge recovery from working, I assure you it is holding the item, since that was the entire reason for the replay in the first place

 

[DaWoblefet]

For the developer: the bug is likely a race condition, but Throat Spray in general should be very late in the checks done after move success (after the Sheer Force-negated block at least). The correct fix is to move Throat Spray to a later event. To be clear, Psychic Noise Throat Spray with Magician on cartridge will not steal an item.