Done Air Lock in pastgens

[Inspirited]

What type of bug are you reporting? Mechanics

What is the bug?
Gen 3/4 Air Lock broke again! After Rayquaza sets Air Lock and leaves the field, that Rayquaza's (it might be tied to the player... I didn't think to test this) Air Lock just does not work anymore for the rest of the game. This is a big deal I swear.

Are you able to replicate it? If so, how?
Yes. For sand and hail, set the weather turn 1. Bring in both a Rayquaza for each player. Swap them both out and bring them in again. They will take weather damage.

I tested rain/sun in a similar fashion only using Swift Swim and Leftovers speed to determin that ray was faster than a Swift Swim Omastar on its first time in and slower on the second due to Air Lock failure. I didn't test Hydro Pump damage like I probably should have.

Air Lock seems to work fine in BW onwards which leads me to suspect some ability announcing semantics with flags is to blame but in all honestly I know nothing.

Air Lock letting sandstorm damage through:
https://replay.pokemonshowdown.com/gen3ubers-2091876056?p2
https://replay.pokemonshowdown.com/gen3ubers-2091878319?p2
https://replay.pokemonshowdown.com/gen4ubers-2091880568

Air Lock letting rain effect Swift Swim:
https://replay.pokemonshowdown.com/gen4ubers-2091884765

 

[HoeenHero]

Old gens code works backwards from the current generation, with each generation making required changes and inheriting everything from the generation that comes after it. It looks like generation 4 overrides the methods used to make airlock/cloud nine work causing this issue. I can't fix this right now because of other obligations.

For whoever gets to this (if I dont get to it first): The quick fix would be changing the existing gen 4 override to clear the ending flag onStart just like in gen 9. A larger goal would be investigating flagging ability states with an ending flag in Battle.singleEvent whenever an ability is ending. Also make sure to clear that flag when the ability re-starts (eg: on swap back in). Doing this for all abilities so we have a way to check if the ability is ending due to a KO/swap out would be useful in general.

 

[Kalaveet]

What type of bug are you reporting? Mechanics

What is the bug?
https://replay.pokemonshowdown.com/gen3ou-2095922728-w87c2ut0v80yarh0ejjm6yscssmhbc3pw
On turn 5, both Slaking and Golduck take sand damage, even though my Golduck has Cloud Nine. It is confirmed that my Golduck has Cloud Nine because of t4, where it didn't take sand damage.
I have tested this on an Emerald cartridge with both sand and hail damage. Even after boom, both Pokemon do not take weather damage if Cloud Nine is active.

https://www.smogon.com/forums/threads/cloud-nine-not-stopping-hail-damage.3739483/
There is also a similar issue with Cloud Nine in gen 6 that apparently has been fixed. Please, fix the issue in gen 3 as well, and make sure to check that Cloud Nine is also active after Explosion and Self-Destruct.

Are you able to replicate it? If so, how?
No, for some reason Cloud Nine did actually activate after this boom: https://play.pokemonshowdown.com/battle-gen3ou-2095961115-jfrs60a820pw2ycz5gaehve32j8adjppw

 

[Waldinji]

What type of bug are you reporting? Mechanics

What is the bug?
We were playing ADV with Air Lock mons , only for Air Lock Revenankh to not block sand in that game right here:
- https://replay.pokemonshowdown.com/gen3customgame-2101705716?p2 (It Blocked on turn 7 , but not turn 16 or 18)
We decided to test with this second game right here:
- https://replay.pokemonshowdown.com/gen3customgame-2101715351?p2
We have inconsistancies with Air Lock Revenankh Blocking Sand on turn 2 , But not turn 5. Not to mention it didn't work at all on rayquaza.

Are you able to replicate it? If so, how?
We were not able to replicate it to the same success as the second game , as We tested one last game before reporting:
- https://replay.pokemonshowdown.com/gen3customgame-2101716975?p2
We had Both air lock & Cloud nine , and both abilities worked 3 Turns in a row for each mon.

 

[DaWoblefet]

Fixed by smudgerox in https://github.com/smogon/pokemon-showdown/pull/10259